From a774506525c4d347fb20a3faf8025c18846c776f Mon Sep 17 00:00:00 2001
From: Christoph Schwarzmeier <christoph.schwarzmeier@fau.de>
Date: Thu, 28 Jul 2022 09:43:39 +0200
Subject: [PATCH] Use correct stencil for bubble model in free-surface
 showcases

---
 apps/showcases/FreeSurface/BubblyPoiseuille.cpp    | 4 ++--
 apps/showcases/FreeSurface/CapillaryWave.cpp       | 4 ++--
 apps/showcases/FreeSurface/DamBreakCylindrical.cpp | 4 ++--
 apps/showcases/FreeSurface/DamBreakRectangular.cpp | 4 ++--
 apps/showcases/FreeSurface/DropImpact.cpp          | 4 ++--
 apps/showcases/FreeSurface/DropWetting.cpp         | 4 ++--
 apps/showcases/FreeSurface/GravityWave.cpp         | 4 ++--
 apps/showcases/FreeSurface/GravityWaveCodegen.cpp  | 4 ++--
 apps/showcases/FreeSurface/MovingDrop.cpp          | 4 ++--
 apps/showcases/FreeSurface/RisingBubble.cpp        | 4 ++--
 apps/showcases/FreeSurface/TaylorBubble.cpp        | 4 ++--
 apps/showcases/FreeSurface/TaylorBubble.prm        | 2 +-
 src/lbm/free_surface/bubble_model/BubbleModel.h    | 2 +-
 13 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/apps/showcases/FreeSurface/BubblyPoiseuille.cpp b/apps/showcases/FreeSurface/BubblyPoiseuille.cpp
index 00ae3e9f4..f3726c245 100644
--- a/apps/showcases/FreeSurface/BubblyPoiseuille.cpp
+++ b/apps/showcases/FreeSurface/BubblyPoiseuille.cpp
@@ -286,8 +286,8 @@ int main(int argc, char** argv)
    std::shared_ptr< bubble_model::BubbleModelBase > bubbleModel = nullptr;
    if (enableBubbleModel)
    {
-      const std::shared_ptr< bubble_model::BubbleModel< CommunicationStencil_T > > bubbleModelDerived =
-         std::make_shared< bubble_model::BubbleModel< CommunicationStencil_T > >(blockForest, enableBubbleSplits);
+      const std::shared_ptr< bubble_model::BubbleModel< LatticeModelStencil_T > > bubbleModelDerived =
+         std::make_shared< bubble_model::BubbleModel< LatticeModelStencil_T > >(blockForest, enableBubbleSplits);
       bubbleModelDerived->initFromFillLevelField(fillFieldID);
 
       bubbleModel = std::static_pointer_cast< bubble_model::BubbleModelBase >(bubbleModelDerived);
diff --git a/apps/showcases/FreeSurface/CapillaryWave.cpp b/apps/showcases/FreeSurface/CapillaryWave.cpp
index d36003bc0..2a6ebb277 100644
--- a/apps/showcases/FreeSurface/CapillaryWave.cpp
+++ b/apps/showcases/FreeSurface/CapillaryWave.cpp
@@ -356,8 +356,8 @@ int main(int argc, char** argv)
    std::shared_ptr< bubble_model::BubbleModelBase > bubbleModel = nullptr;
    if (enableBubbleModel)
    {
-      const std::shared_ptr< bubble_model::BubbleModel< CommunicationStencil_T > > bubbleModelDerived =
-         std::make_shared< bubble_model::BubbleModel< CommunicationStencil_T > >(blockForest, enableBubbleSplits);
+      const std::shared_ptr< bubble_model::BubbleModel< LatticeModelStencil_T > > bubbleModelDerived =
+         std::make_shared< bubble_model::BubbleModel< LatticeModelStencil_T > >(blockForest, enableBubbleSplits);
       bubbleModelDerived->initFromFillLevelField(fillFieldID);
       bubbleModelDerived->setAtmosphere(Cell(domainSize[0] - uint_c(1), domainSize[1] - uint_c(1), uint_c(0)),
                                         real_c(1));
diff --git a/apps/showcases/FreeSurface/DamBreakCylindrical.cpp b/apps/showcases/FreeSurface/DamBreakCylindrical.cpp
index 129cda8de..d082b5fcc 100644
--- a/apps/showcases/FreeSurface/DamBreakCylindrical.cpp
+++ b/apps/showcases/FreeSurface/DamBreakCylindrical.cpp
@@ -465,8 +465,8 @@ int main(int argc, char** argv)
    std::shared_ptr< bubble_model::BubbleModelBase > bubbleModel = nullptr;
    if (enableBubbleModel)
    {
-      const std::shared_ptr< bubble_model::BubbleModel< CommunicationStencil_T > > bubbleModelDerived =
-         std::make_shared< bubble_model::BubbleModel< CommunicationStencil_T > >(blockForest, enableBubbleSplits);
+      const std::shared_ptr< bubble_model::BubbleModel< LatticeModelStencil_T > > bubbleModelDerived =
+         std::make_shared< bubble_model::BubbleModel< LatticeModelStencil_T > >(blockForest, enableBubbleSplits);
       bubbleModelDerived->initFromFillLevelField(fillFieldID);
       bubbleModelDerived->setAtmosphere(
          Cell(domainSize[0] - uint_c(1), domainSize[1] - uint_c(1), domainSize[2] - uint_c(1)), real_c(1));
diff --git a/apps/showcases/FreeSurface/DamBreakRectangular.cpp b/apps/showcases/FreeSurface/DamBreakRectangular.cpp
index e3a4a5e4e..6c7109b16 100644
--- a/apps/showcases/FreeSurface/DamBreakRectangular.cpp
+++ b/apps/showcases/FreeSurface/DamBreakRectangular.cpp
@@ -454,8 +454,8 @@ int main(int argc, char** argv)
    std::shared_ptr< bubble_model::BubbleModelBase > bubbleModel = nullptr;
    if (enableBubbleModel)
    {
-      const std::shared_ptr< bubble_model::BubbleModel< CommunicationStencil_T > > bubbleModelDerived =
-         std::make_shared< bubble_model::BubbleModel< CommunicationStencil_T > >(blockForest, enableBubbleSplits);
+      const std::shared_ptr< bubble_model::BubbleModel< LatticeModelStencil_T > > bubbleModelDerived =
+         std::make_shared< bubble_model::BubbleModel< LatticeModelStencil_T > >(blockForest, enableBubbleSplits);
       bubbleModelDerived->initFromFillLevelField(fillFieldID);
       bubbleModelDerived->setAtmosphere(Cell(domainSize[0] - uint_c(1), domainSize[1] - uint_c(1), uint_c(0)),
                                         real_c(1));
diff --git a/apps/showcases/FreeSurface/DropImpact.cpp b/apps/showcases/FreeSurface/DropImpact.cpp
index 143885a05..e5df0d56d 100644
--- a/apps/showcases/FreeSurface/DropImpact.cpp
+++ b/apps/showcases/FreeSurface/DropImpact.cpp
@@ -279,8 +279,8 @@ int main(int argc, char** argv)
    std::shared_ptr< bubble_model::BubbleModelBase > bubbleModel = nullptr;
    if (enableBubbleModel)
    {
-      const std::shared_ptr< bubble_model::BubbleModel< CommunicationStencil_T > > bubbleModelDerived =
-         std::make_shared< bubble_model::BubbleModel< CommunicationStencil_T > >(blockForest, enableBubbleSplits);
+      const std::shared_ptr< bubble_model::BubbleModel< LatticeModelStencil_T > > bubbleModelDerived =
+         std::make_shared< bubble_model::BubbleModel< LatticeModelStencil_T > >(blockForest, enableBubbleSplits);
       bubbleModelDerived->initFromFillLevelField(fillFieldID);
       bubbleModelDerived->setAtmosphere(
          Cell(domainSize[0] - uint_c(1), domainSize[1] - uint_c(1), domainSize[2] - uint_c(1)), real_c(1));
diff --git a/apps/showcases/FreeSurface/DropWetting.cpp b/apps/showcases/FreeSurface/DropWetting.cpp
index 20445dead..c2aca47f5 100644
--- a/apps/showcases/FreeSurface/DropWetting.cpp
+++ b/apps/showcases/FreeSurface/DropWetting.cpp
@@ -316,8 +316,8 @@ int main(int argc, char** argv)
    std::shared_ptr< bubble_model::BubbleModelBase > bubbleModel = nullptr;
    if (enableBubbleModel)
    {
-      const std::shared_ptr< bubble_model::BubbleModel< CommunicationStencil_T > > bubbleModelDerived =
-         std::make_shared< bubble_model::BubbleModel< CommunicationStencil_T > >(blockForest, enableBubbleSplits);
+      const std::shared_ptr< bubble_model::BubbleModel< LatticeModelStencil_T > > bubbleModelDerived =
+         std::make_shared< bubble_model::BubbleModel< LatticeModelStencil_T > >(blockForest, enableBubbleSplits);
       bubbleModelDerived->initFromFillLevelField(fillFieldID);
       bubbleModelDerived->setAtmosphere(
          Cell(domainSize[0] - uint_c(1), domainSize[1] - uint_c(1), domainSize[2] - uint_c(1)), real_c(1));
diff --git a/apps/showcases/FreeSurface/GravityWave.cpp b/apps/showcases/FreeSurface/GravityWave.cpp
index 6faca3c70..10b52e266 100644
--- a/apps/showcases/FreeSurface/GravityWave.cpp
+++ b/apps/showcases/FreeSurface/GravityWave.cpp
@@ -446,8 +446,8 @@ int main(int argc, char** argv)
    std::shared_ptr< bubble_model::BubbleModelBase > bubbleModel = nullptr;
    if (enableBubbleModel)
    {
-      const std::shared_ptr< bubble_model::BubbleModel< CommunicationStencil_T > > bubbleModelDerived =
-         std::make_shared< bubble_model::BubbleModel< CommunicationStencil_T > >(blockForest, enableBubbleSplits);
+      const std::shared_ptr< bubble_model::BubbleModel< LatticeModelStencil_T > > bubbleModelDerived =
+         std::make_shared< bubble_model::BubbleModel< LatticeModelStencil_T > >(blockForest, enableBubbleSplits);
       bubbleModelDerived->initFromFillLevelField(fillFieldID);
       bubbleModelDerived->setAtmosphere(Cell(domainSize[0] - uint_c(1), domainSize[1] - uint_c(1), uint_c(0)),
                                         real_c(1));
diff --git a/apps/showcases/FreeSurface/GravityWaveCodegen.cpp b/apps/showcases/FreeSurface/GravityWaveCodegen.cpp
index a6b41aea0..1658f9290 100644
--- a/apps/showcases/FreeSurface/GravityWaveCodegen.cpp
+++ b/apps/showcases/FreeSurface/GravityWaveCodegen.cpp
@@ -447,8 +447,8 @@ int main(int argc, char** argv)
    std::shared_ptr< bubble_model::BubbleModelBase > bubbleModel = nullptr;
    if (enableBubbleModel)
    {
-      const std::shared_ptr< bubble_model::BubbleModel< CommunicationStencil_T > > bubbleModelDerived =
-         std::make_shared< bubble_model::BubbleModel< CommunicationStencil_T > >(blockForest, enableBubbleSplits);
+      const std::shared_ptr< bubble_model::BubbleModel< LatticeModelStencil_T > > bubbleModelDerived =
+         std::make_shared< bubble_model::BubbleModel< LatticeModelStencil_T > >(blockForest, enableBubbleSplits);
       bubbleModelDerived->initFromFillLevelField(fillFieldID);
       bubbleModelDerived->setAtmosphere(Cell(domainSize[0] - uint_c(1), domainSize[1] - uint_c(1), uint_c(0)),
                                         real_c(1));
diff --git a/apps/showcases/FreeSurface/MovingDrop.cpp b/apps/showcases/FreeSurface/MovingDrop.cpp
index 478ee193c..9ddba4ae8 100644
--- a/apps/showcases/FreeSurface/MovingDrop.cpp
+++ b/apps/showcases/FreeSurface/MovingDrop.cpp
@@ -243,8 +243,8 @@ int main(int argc, char** argv)
    std::shared_ptr< bubble_model::BubbleModelBase > bubbleModel = nullptr;
    if (enableBubbleModel)
    {
-      const std::shared_ptr< bubble_model::BubbleModel< CommunicationStencil_T > > bubbleModelDerived =
-         std::make_shared< bubble_model::BubbleModel< CommunicationStencil_T > >(blockForest, enableBubbleSplits);
+      const std::shared_ptr< bubble_model::BubbleModel< LatticeModelStencil_T > > bubbleModelDerived =
+         std::make_shared< bubble_model::BubbleModel< LatticeModelStencil_T > >(blockForest, enableBubbleSplits);
       bubbleModelDerived->initFromFillLevelField(fillFieldID);
       bubbleModelDerived->setAtmosphere(
          Cell(domainSize[0] - uint_c(1), domainSize[1] - uint_c(1), domainSize[2] - uint_c(1)), real_c(1));
diff --git a/apps/showcases/FreeSurface/RisingBubble.cpp b/apps/showcases/FreeSurface/RisingBubble.cpp
index 3dabdf5da..1dbe5566d 100644
--- a/apps/showcases/FreeSurface/RisingBubble.cpp
+++ b/apps/showcases/FreeSurface/RisingBubble.cpp
@@ -324,8 +324,8 @@ int main(int argc, char** argv)
    std::shared_ptr< bubble_model::BubbleModelBase > bubbleModel = nullptr;
    if (enableBubbleModel)
    {
-      const std::shared_ptr< bubble_model::BubbleModel< CommunicationStencil_T > > bubbleModelDerived =
-         std::make_shared< bubble_model::BubbleModel< CommunicationStencil_T > >(blockForest, enableBubbleSplits);
+      const std::shared_ptr< bubble_model::BubbleModel< LatticeModelStencil_T > > bubbleModelDerived =
+         std::make_shared< bubble_model::BubbleModel< LatticeModelStencil_T > >(blockForest, enableBubbleSplits);
       bubbleModelDerived->initFromFillLevelField(fillFieldID);
 
       bubbleModel = std::static_pointer_cast< bubble_model::BubbleModelBase >(bubbleModelDerived);
diff --git a/apps/showcases/FreeSurface/TaylorBubble.cpp b/apps/showcases/FreeSurface/TaylorBubble.cpp
index 3ec4eea3d..16dc2087c 100644
--- a/apps/showcases/FreeSurface/TaylorBubble.cpp
+++ b/apps/showcases/FreeSurface/TaylorBubble.cpp
@@ -354,8 +354,8 @@ int main(int argc, char** argv)
    std::shared_ptr< bubble_model::BubbleModelBase > bubbleModel = nullptr;
    if (enableBubbleModel)
    {
-      const std::shared_ptr< bubble_model::BubbleModel< CommunicationStencil_T > > bubbleModelDerived =
-         std::make_shared< bubble_model::BubbleModel< CommunicationStencil_T > >(blockForest, enableBubbleSplits);
+      const std::shared_ptr< bubble_model::BubbleModel< LatticeModelStencil_T > > bubbleModelDerived =
+         std::make_shared< bubble_model::BubbleModel< LatticeModelStencil_T > >(blockForest, enableBubbleSplits);
       bubbleModelDerived->initFromFillLevelField(fillFieldID);
 
       bubbleModel = std::static_pointer_cast< bubble_model::BubbleModelBase >(bubbleModelDerived);
diff --git a/apps/showcases/FreeSurface/TaylorBubble.prm b/apps/showcases/FreeSurface/TaylorBubble.prm
index a2b289aee..ee3d8c9f5 100644
--- a/apps/showcases/FreeSurface/TaylorBubble.prm
+++ b/apps/showcases/FreeSurface/TaylorBubble.prm
@@ -8,7 +8,7 @@ BlockForestParameters
 
 DomainParameters
 {
-   tubeDiameter      32;
+   tubeDiameter      16;
    bubbleDiameter    0.75;             // value multiplied with tubeDiameter
    bubbleHeight      3;                // value multiplied with tubeDiameter
    bubbleBottomEnd   < 0.5, 0.5, 1 >;  // initial cylindrical bubble's bottom end center (values multiplied with tubeDiameter)
diff --git a/src/lbm/free_surface/bubble_model/BubbleModel.h b/src/lbm/free_surface/bubble_model/BubbleModel.h
index a22d540ea..a71a47fb3 100644
--- a/src/lbm/free_surface/bubble_model/BubbleModel.h
+++ b/src/lbm/free_surface/bubble_model/BubbleModel.h
@@ -209,7 +209,7 @@ class BubbleModel : public BubbleModelBase
    MergeInformation mergeInformation_;
 
    // communication scheme for the bubble field
-   blockforest::communication::UniformBufferedScheme< Stencil_T > bubbleFieldCommunication_;
+   blockforest::communication::UniformBufferedScheme< StencilForSplit_T > bubbleFieldCommunication_;
 
    // store split information, i.e., hints for splitting; store only hints since merges have to be processed first
    struct SplitHint
-- 
GitLab