diff --git a/CMakeLists.txt b/CMakeLists.txt index 85125dcaf83ccf81a7ef108eb38f92b4b3ee89ed..0ee1e578c7a963ec1f5f40c907fce8aa647b1b6b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1027,31 +1027,22 @@ endif() option ( WALBERLA_THREAD_SAFE_LOGGING "Enables/Disables thread-safe logging" ON ) if ( WALBERLA_BUILD_WITH_OPENMP ) - if ( WALBERLA_CXX_COMPILER_IS_INTEL ) + if ( WALBERLA_CXX_COMPILER_IS_INTEL AND "${CMAKE_CXX_COMPILER_VERSION}" VERSION_LESS "16.0.3" ) add_flag ( CMAKE_C_FLAGS "-openmp" ) add_flag ( CMAKE_CXX_FLAGS "-openmp" ) - elseif ( CMAKE_COMPILER_IS_GNUCXX ) - add_flag ( CMAKE_C_FLAGS "-fopenmp" ) - add_flag ( CMAKE_CXX_FLAGS "-fopenmp" ) - elseif ( WALBERLA_CXX_COMPILER_IS_CLANG ) - add_flag ( CMAKE_C_FLAGS "-fopenmp" ) - add_flag ( CMAKE_CXX_FLAGS "-fopenmp" ) - elseif ( WALBERLA_CXX_COMPILER_IS_MSVC ) - add_flag ( CMAKE_C_FLAGS "/openmp" ) - add_flag ( CMAKE_CXX_FLAGS "/openmp" ) - elseif ( WALBERLA_CXX_COMPILER_IS_IBM ) - add_flag ( CMAKE_C_FLAGS "-qsmp=omp" ) - add_flag ( CMAKE_CXX_FLAGS "-qsmp=omp" ) - # There has been an internal compiler error with the IBM compiler, so WALBERLA_THREAD_SAFE_LOGGING is disabled by default for this compiler - set ( WALBERLA_THREAD_SAFE_LOGGING OFF CACHE BOOL "Enables/Disables thread-safe logging" FORCE ) elseif ( WALBERLA_CXX_COMPILER_IS_NEC ) - add_flag ( CMAKE_C_FLAGS "-Popenmp" ) - add_flag ( CMAKE_CXX_FLAGS "-Popenmp" ) + add_flag ( CMAKE_C_FLAGS "-Popenmp" ) + add_flag ( CMAKE_CXX_FLAGS "-Popenmp" ) + else() + find_package( OpenMP ) + add_flag ( CMAKE_C_FLAGS "${OpenMP_C_FLAGS}" ) + add_flag ( CMAKE_CXX_FLAGS "${OpenMP_CXX_FLAGS}" ) + list ( APPEND SERVICE_LIBS ${OpenMP_CXX_LIBRARIES} ) endif() else() if ( WALBERLA_CXX_COMPILER_IS_CRAY ) - add_flag ( CMAKE_C_FLAGS "-h noomp" ) - add_flag ( CMAKE_CXX_FLAGS "-h noomp" ) + add_flag ( CMAKE_C_FLAGS "-h noomp" ) + add_flag ( CMAKE_CXX_FLAGS "-h noomp" ) endif() endif() ############################################################################################################################ diff --git a/src/core/Abort.cpp b/src/core/Abort.cpp index 910dcb209f178dcdd1595477f8339eb08726d06a..1ff3ad2cb045f2132518f6a854fd79f48053a1a8 100644 --- a/src/core/Abort.cpp +++ b/src/core/Abort.cpp @@ -63,7 +63,7 @@ void Abort::defaultAbort( const std::string & logMessage, const std::string & ca #ifdef _OPENMP - #pragma omp critical (abort) + #pragma omp critical (Abort_abort) { #endif diff --git a/src/core/math/Random.cpp b/src/core/math/Random.cpp index 72707f208e5053cba44daed005e2685f86333e8b..5acdc01d34fbe236fcb94fb98fa952a92564eaa2 100644 --- a/src/core/math/Random.cpp +++ b/src/core/math/Random.cpp @@ -43,7 +43,7 @@ std::mt19937 & getGenerator() // std::mt19937_64 void seedRandomGenerator( const std::mt19937::result_type & seed ) { #ifdef _OPENMP - #pragma omp critical (random) + #pragma omp critical (Random_random) #endif internal::getGenerator().seed( seed ); } diff --git a/src/core/math/Random.h b/src/core/math/Random.h index ec61aa51d65b76f3a10c243086d08a48eb166590..d63d2e7ede6338606219e743d7fc44444ca23010 100644 --- a/src/core/math/Random.h +++ b/src/core/math/Random.h @@ -59,7 +59,7 @@ INT intRandom( const INT min, const INT max, std::mt19937 & generator ) INT value; #ifdef _OPENMP - #pragma omp critical (random) + #pragma omp critical (Random_random) #endif { value = distribution( generator ); } @@ -76,7 +76,7 @@ inline char intRandom<char>( const char min, const char max, std::mt19937 & gene char value; #ifdef _OPENMP - #pragma omp critical (random) + #pragma omp critical (Random_random) #endif { value = static_cast<char>( distribution( generator ) ); } @@ -93,7 +93,7 @@ inline unsigned char intRandom<unsigned char>( const unsigned char min, const un unsigned char value; #ifdef _OPENMP - #pragma omp critical (random) + #pragma omp critical (Random_random) #endif { value = static_cast<unsigned char>( distribution( generator ) ); } @@ -110,7 +110,7 @@ inline signed char intRandom<signed char>( const signed char min, const signed c signed char value; #ifdef _OPENMP - #pragma omp critical (random) + #pragma omp critical (Random_random) #endif { value = static_cast<signed char>( distribution( generator ) ); } @@ -168,7 +168,7 @@ REAL realRandom( const REAL min = REAL(0), const REAL max = REAL(1), std::mt1993 REAL value; #ifdef _OPENMP - #pragma omp critical (random) + #pragma omp critical (Random_random) #endif { value = distribution( generator ); } diff --git a/src/field/interpolators/NearestNeighborFieldInterpolator.h b/src/field/interpolators/NearestNeighborFieldInterpolator.h index 45e9110de725173af89a4aed20e1d6290b5278a5..975c55edb4c52d0ea197391a88b271588bbf7729 100644 --- a/src/field/interpolators/NearestNeighborFieldInterpolator.h +++ b/src/field/interpolators/NearestNeighborFieldInterpolator.h @@ -121,7 +121,7 @@ public: *interpolationResultBegin = baseField_(curCell, f); ++interpolationResultBegin; } - break; + return; } } } diff --git a/tests/fft/FftTest.cpp b/tests/fft/FftTest.cpp index 58d80c486de68e7c33d9e2a14263fd08cdd0eeb7..99e934dbfca25d21ad8fb7883634ac6d591c6bd4 100644 --- a/tests/fft/FftTest.cpp +++ b/tests/fft/FftTest.cpp @@ -41,7 +41,7 @@ int main (int argc, char** argv) { Field_T *data_in = block->getData< Field_T >( originalFieldId ); Field_T *data_out = block->getData< Field_T >( fftFieldId ); - WALBERLA_FOR_ALL_CELLS_XYZ(data_in, { + WALBERLA_FOR_ALL_CELLS_XYZ_OMP(data_in, omp critical, { Vector3<real_t> point( real_c(x), real_c(y), real_c(z) ); blocks->transformBlockLocalToGlobal(point, *block); data_in->get(x,y,z) = real_c(std::ranlux48_base(uint_c(point[0])+(uint_c(point[1])*L+uint_c(point[2]))*L)())*real_c(std::pow(2,-48));