Topics for Refactoring Week
Hi,
I thought it might be a good idea to start collecting topics for the planned code refactoring. Please feel free to extend this.
Cheers
Marcus
| topic | comment/explanation | related issues |
|---|---|---|
| forms interface | in order to better be able to exchange forms we should clean-up and reduce the number of different integrate(), integrateAll(), integrateRow(), integrateRow0() methods and discuss whether the various assemble2D() methods are still required |
#84, #92 (closed), #145 |
| forms deprecation | we should get rid of the remaining forms in form_hyteg_manual and the old form_hyteg_generated forms that are not from HFG | #153 (closed) |
| implement matrix creation for the new vector and block operators and streamline the whole approach | #110, #125 (closed) | |
| P1-3D-Stencil-Assembly | see issue | #115 |
decide which of these operators should be supported and which removed:
|
#165 (closed) | |
| namespaces |
ccd5f369 inspired me in adding a row here. Namespaces are all over the place, we may want to have that sorted out (i.e. only single namespace hyteg:: or add some more structure by directories, or something else ...). Our doxygen documentation and IDE code completion would also really benefit. |
none |
| DGFunction | decide what to do with this class; the problem IMHO is that it has deviated significantly from e.g. VertexDoFFunction or EdgeDoFFunction w.r.t. supported functionality; also it seems to only support 2D | none |
| we should not use PetscInt outside of any code that is explicitly Petsc-related (e.g. for numerators in apps), I think we can replace it by in64_t or similar and then cast to PetscInt later | #125 (closed), #161 (closed) | |
| real_t to float | pretty sure that mapping real_t to float breaks many things | #164 |
| branch cleanup | we should try to cleanup some of the old branches that are still in the repo | none |