From 538b2a553f1b263281fa39c5b6a23c340d0a4d29 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20H=C3=B6nig?= <jan.hoenig@fau.de>
Date: Wed, 24 Nov 2021 12:53:04 +0100
Subject: [PATCH] Identification of TODOs
---
pystencils/data_types.py | 6 ++++--
pystencils/transformations.py | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/pystencils/data_types.py b/pystencils/data_types.py
index 84af2f7f5..9bf8375bf 100644
--- a/pystencils/data_types.py
+++ b/pystencils/data_types.py
@@ -79,9 +79,10 @@ def assumptions_from_dtype(dtype):
# noinspection PyPep8Naming
class address_of(sp.Function):
- # TODO: ask Martin
+ # DONE: ask Martin
# TODO: documentation
# TODO: move function to `functions.py`
+ # this is '&' in C
is_Atom = True
def __new__(cls, arg):
@@ -644,7 +645,8 @@ if int(sympy_version[0]) * 100 + int(sympy_version[1]) >= 109:
class Type(sp.Atom):
# TODO: why is our type system dependent on sympy???
- # TODO: ask Martin
+ # DONE: ask Martin
+ # TODO: inherits from sp.Atom because of cast function (and maybe others)
def __new__(cls, *args, **kwargs):
return sp.Basic.__new__(cls)
diff --git a/pystencils/transformations.py b/pystencils/transformations.py
index 1175580f7..0c6d00658 100644
--- a/pystencils/transformations.py
+++ b/pystencils/transformations.py
@@ -805,6 +805,8 @@ def cleanup_blocks(node: ast.Node) -> None:
class KernelConstraintsCheck:
+ # TODO: Logs
+ # TODO: specification
"""Checks if the input to create_kernel is valid.
Test the following conditions:
--
GitLab