Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • W waLBerla
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • waLBerla
  • waLBerla
  • Merge requests
  • !299

staggered boundary generation: direction index should point to fluid cell when...

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Michael Kuron requested to merge pystencils_boundary into master Jun 30, 2020
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 3

When inner_or_boundary=False, the index vector contains the boundary cells, so the direction should point to the fluid cell. When inner_or_boundary=True, the index vector contains the fluid cells and the direction points to the boundary cell.

Technically, this constitutes an API change because it was possible to work around in your own Boundary class. However, this problem was only introduced two months ago in !266 (merged), so we better fix this inconsistent behavior.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: pystencils_boundary