Dominik Thoennes authored 3 years ago and Christoph Schwarzmeier committed 3 years ago

instead of the custom walberla_add_module the `add_library` command is now used for all folders in `src` to create libraries which can then be used as cmake targets

Delete Doxygen blocks duplicated in both .h and .cpp files.
Fix incorrect argument names in \param blocks. Fix filenames
in \file blocks. Fix broken Doxygen syntax (broken numerated
lists containing more than 9 items, invalid HTML tags, broken
links in \ref and malformed math equations). Wrap code blocks
inside \code ... \endcode.

This prevents possible deadlocks during reduction at the cost of an
additional communication.

constructing an empty std::set has almost no cost

Michael Kuron authored 4 years ago and Markus Holzer committed 4 years ago

Some optional components use Boost MultiArray and PropertyTree, so we still include the headers if available.
We also still search std::experimental for any, filesystem and optional because some otherwise C++17-compliant compilers did not support them in std until recently.

Markus Holzer authored 4 years ago and Dominik Thoennes committed 4 years ago

also clean up some old leftovers nearby

Our own wrappers was only used in one place anyway and did not all allow for specify a reason string.

If a process started by mpiexec finishes too quickly, sometimes some of the other processes are not started.
It is unclear whether this is an OpenMPI or macOS bug, but appears significantly more often since moving from macOS 10.13 to 10.15. OpenMPI 4.0.1 and 3.0.0 both show the issue on macOS 10.15.