Skip to content
Snippets Groups Projects

Fixing translation variance of expressions in forms.

Merged Nils Kohl requested to merge kohl/fix-translation-variance-of-expressions into main
1 unresolved thread

Up until now, we apparently have not tested translation variant expressions in forms. For affine domain transformations (aka no blending) the implementation falsely assumed that the entire form is translation invariant. But this is of course not true. It only applies to the Jacobian.

The downside of this simple fix is that I guess it will produce unused variables. But let's see.

Merge request reports

Pipeline #66508 passed with warnings

Pipeline passed with warnings for 5beadca8 on kohl/fix-translation-variance-of-expressions

Approved by

Merged by Nils KohlNils Kohl 9 months ago (Jun 4, 2024 12:00pm UTC)

Merge details

  • Changes merged into main with 1999497e.
  • Deleted the source branch.

Pipeline #66526 passed with warnings

Pipeline passed with warnings for 1999497e on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply