Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • hyteg hyteg
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • hyteg
  • hyteghyteg
  • Issues
  • #150
Closed
Open
Issue created May 03, 2021 by Marcus Mohr@mohrDeveloper

Update interface of MMOCTransport.step()

Hi,

just a small issue, but as it effects one of the tutorials I wanted to document it. So we don't forget fixing it in a nice way. The step() method of the MMOCTransport class currently has the following interface

void step( const FunctionType& c,
           const FunctionType& ux,
           const FunctionType& uy,
           const FunctionType& uz,
           const FunctionType& uxLastTimeStep,
           const FunctionType& uyLastTimeStep,
           const FunctionType& uzLastTimeStep,
           const uint_t&       level,
           const DoFType&      flag,
           const real_t&       dt,
           const uint_t&       innerSteps,
           const bool&         resetParticles                  = true,
           const bool&         globalMaxLimiter                = true,
           const bool&         setParticlesOutsideDomainToZero = false )

This is our old-school approach to vector functions and does not work well together with the new CSFVectorFunction class, in the case of a 2D problem. As then there is no third component to pass to step(). The following code line

transport.step( c, u.uvw[0], u.uvw[1], u.uvw[2], u.uvw[0], u.uvw[1], u.uvw[2], maxLevel, All, dt, 1, true );

let's tutorials/07_IsoviscousConvectionAnnulus/IsoviscousConvectionAnnulus crash currently when run with the default 2D mesh file.

Going to hot-fix the tutorial now, before adressing the issue in a more consistent way.

Cheers
Marcus

Assignee
Assign to
Time tracking