Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • hyteg hyteg
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • hyteg
  • hyteghyteg
  • Issues
  • #169
Closed
Open
Issue created Dec 17, 2021 by Marcus Mohr@mohrDeveloper

Boundary Conditions and Constructors of Function classes

Hi,

I just noted a small inconsistency in the constructors of the P*VectorFunctions compared to those of the scalar functions. All of

  • P1Function
  • P2Function
  • EdgeDoFFunction
  • FaceDoFFunction

provide a constructor version that allows to set a BoundaryCondition. The constructor which does not allow this, in turn delegates to the other one using our default variant BoundaryCondition::create0123BC() to generate a B.C. object.

  • P1VectorFunction
  • P2VectorFunction

both currently provide only a single constructor that

  • does not allow to set the boundary condition
  • and also does not set the default

IMHO we should fix this by extending the two classes.

Cheers
Marcus

Assignee
Assign to
Time tracking