Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • lbmpy lbmpy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 15
    • Issues 15
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pycodegen
  • lbmpylbmpy
  • Merge requests
  • !14

Disable cse_global on create_lb_collision_rule for Sympy < 1.2

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Michael Kuron requested to merge csebug into master Nov 18, 2019
  • Overview 4
  • Commits 1
  • Pipelines 2
  • Changes 1

I have this weird problem with cse_global and the fluctuating LB. It works fine with SymPy 1.2 and produces wrong temperatures with SymPy 1.1.1. I have bisected it down to this change: https://github.com/sympy/sympy/pull/13221. My patch disables cse_global if it's enabled and displays a warning on the incriminating SymPy version. I used Mathematica to plug the subexpressions back into the main expressions and get the same thing with both SymPy versions, so I have no idea what the actual problem is. Thus I can't rule out that it only occurs with the fluctuating LB. Until we know for sure, it seems safest to just disable cse_global on that old SymPy version entirely.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: csebug