Regression !300

In !300 (merged) all written field sizes are added to the SympyAssignment as unknown parameters. This solves the problem that all field sizes need to be passed as arguments when using NT stores with non-x86 architectures. However, it introduces two problems.

1. In all other cases these parameters are not used. Thus waLBerla fails in some cases when compiled with -Wall. Other than that it is not nice either to pass unused parameters.

2. For the GPU code generation problems arose with the usage of get_parameters in waLBerla: https://i10git.cs.fau.de/pycodegen/pystencils/-/blob/master/pystencils/astnodes.py#L244

Overall it seems that the easiest way to fix the problem is to only pass the additional size arguments when needed and in no other cases.

assigned to @holzer

added 1 commit

• ff36a6b6 - Fixed notebook one

Compare with previous version

added 1 commit

• 40b3d172 - Use all written field sizes only in special case

Compare with previous version

changed title from Upgrade sympy to Regression !300

changed the description

requested review from @kuron

I have only reviewed 40b3d172, which is what fixes the regression from !300 (merged). That commit looks good to me and fixes the issue. The fourteen other commits are unrelated and should be moved to a separate branch before I can merge this one.

closed