Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • pystencils pystencils
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pycodegen
  • pystencilspystencils
  • Merge requests
  • !348

Fix integration pipeline

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Daniel Bauer requested to merge terraneo/pystencils:bauerd/fix-vectorize-castfunc into master Sep 04, 2023
  • Overview 0
  • Commits 13
  • Pipelines 0
  • Changes 8

This MR fixes several issues with the integration pipeline.

  1. !349 (closed).

  2. Fixes an oversight introduced in !344 (merged). The issue was with expressions like:

    a: scalar float = CastFunc(b: vector float, float)

    The mentioned MR used get_type_of_expression to determine whether an expression will be vectorized. That works in most cases due to type collation but fails for CastFuncs, which are always vectorized. This MR replaces get_type_of_expression by a small helper function that checks whether an expression is entirely scalar or requires additional vector casts.

Edited Sep 07, 2023 by Daniel Bauer
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bauerd/fix-vectorize-castfunc