Fix get_type_of_expression for constants like sympy.pi

Problem: some constant expressions are neither Float,Integer,Rational and don't have arguments.

>>> from sympy import *
>>> isinstance(pi, Integer)
False
>>> isinstance(pi, Float)
False
>>> isinstance(pi, Rational)
False
>>> pi.args
()

changed the description

If I see this correctly, this changes the integer datatype from int32 to int64 on most architectures.

We should check with lbmpy and pygrandchem if this breaks anything. Have you tried the unittests in pycodegen, with this change?

create_type('int') is always int64 since Python types and not C types are assumed by Numpy. The same as float defaults to float64. This is quite confusing and we should maybe disallow that.

I'd prefer int32 but I did not want to change the code. Thought int64 would be more explicit what is happening here.

Also create_type('not_existing_type') can produce very strage errors in other places of pystencils.

added 1 commit

• b87eeadf - Fix get_type_of_expression for constants like sympy.pi

Compare with previous version

I changed it to int.

merged

mentioned in commit e7a8d3ce