Refactor source tree layout
Relates to #75 (closed).
-
Migrate package to src
directory -
Migrate tests to tests
directory and updatepytest
configuration -
Fix various pipelines and CI containers
(pyproject.toml
migration was moved to !364 (merged))
Merge request reports
Activity
requested review from @holzer
assigned to @da15siwa
added 1 commit
- 1c79772f - fix format and dependencies. remove distutils from Cython extension module.
- Resolved by Frederik Hennig
Actually, I think we should change the source tree right away. Is there a good reason to wait for this?
- Resolved by Frederik Hennig
@holzer I've run into some problems concerning our single Cython extension module (
pystencils.boundaries.createindexlistcython
). Building it conditionally on the user's machine through theuse_cython
package variant does not work, and I'm not sure it ever worked. For Cython to be available, it needs to be specified as a build dependency, instead of a project dependency. The discovery code in the oldsetup.py
seems not to work since unless Cython is specified as a build dependency, it cannot be imported by the setup script.Right now I don't see any way to build the extension module conditionally. So there's two options: Either always build it - but then we will either have to provide platform-specific wheels, or the users will always face significantly increased install times, even if in 99% of cases they don't even use that extension module. Or remove it, and accept slower runtimes of this particular piece of code.
Personally, I'd opt for removing it.
Edited by Frederik Hennig
added 3 commits
-
b53718a9...4e579214 - 2 commits from branch
pycodegen:master
- 5578214a - Merge branch 'master' into refactor_packaging
-
b53718a9...4e579214 - 2 commits from branch
added 2 commits