Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • pystencils pystencils
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 16
    • Issues 16
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pycodegen
  • pystencilspystencils
  • Merge requests
  • !38

Implement sp.Sum, sp.Product

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Stephan Seitz requested to merge seitz/pystencils:sum-prod into master Aug 19, 2019
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 3

Sum and Product have a indexing variable which is a Atom but not a free symbol. So logic, that defines the undefined symbols in a SympyAssignment should not be atoms(sp.Symbol) but free_symbols. sp.Indexed from the ResolvedFieldAcesses forms an edge case. So we could also use atoms(sp.Symbol).intersection(...free_symbols).

I hope I extracted from my fork all the necessary code to implement this feature.

Edited Aug 19, 2019 by Stephan Seitz
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: sum-prod