Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • W waLBerla
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 41
    • Issues 41
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • waLBerla
  • waLBerla
  • Merge requests
  • !350

Changes in mesa_pd functionality for halfspaces

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Christoph Rettinger requested to merge mr_mesapd_fixes into master Oct 20, 2020
  • Overview 0
  • Commits 3
  • Pipelines 3
  • Changes 5

This fixes some problems with halfspace (=planes) in mesapd:

  • constructor provided a default normal which does not make sense the current implementation of sending shapes requires pack/unpack to be called on an actual object of the shape type, this requiring a default constructor.
  • the provided normal is not further checked if it is normalized, and thus now calls normalize to ensure this
  • the contains and ray-intersection still accounted for a possible half space rotation which according to the doc of the half space should not be the case. This is thus removed.
  • documentation fixed and improved in some points
Edited Oct 21, 2020 by Christoph Rettinger
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mr_mesapd_fixes