CMake refactoring

• Move all compiler specific settings to extra files in cmake/compileroptions
• introduces minimal versions for the compiler so that std::filesystem is fully supported (according to this table
• remove testfilesystem and enforce compiler/libstd version where it is implemented in std::filesystem
• bump minimal version to cmake 3.24
• use CMAKE_COMPILE_WARNING_AS_ERROR instead of adding these flags manually
• removed a few old work arounds for unsupported compilers
• removed compiler
  • PGI
  • NEC SX

assigned to @ob28imeq

added 1 commit

• 62840265 - moved the rest of the compiler specific parts to the extra files

Compare with previous version

changed the description

added 1 commit

• 429fbc67 - added versions checks for the compilers to at least support

Compare with previous version

changed the description

requested review from @da15siwa

requested review from @thoennes and removed review request for @da15siwa

Even though it introduces some duplication like setting DEBUGOPTIMIZED flags in multiple locations I like this MR.

I wonder if it would be worth removing some of the workarounds we have for the different compilers. For example there seams to be some stuff specifically for gcc 5 which probably can be removed.

Just out of curiosity: Why was 3.24 chosen as a minimal version?

added 3 commits

• 303f385c - removed old gcc workaround
• 7d44c848 - some reformatting and removing of compiler checks in compiler specific
• a5d02458 - moved pybind11 specifc setting for intel compiler to the intel.cmake

Compare with previous version

added 2 commits

• 4f0ea409 - removed workaround for cmake version 3.11
• 6604565c - some typo in error message and reformatting

Compare with previous version

added 2 commits

• 2a9d4608 - add minimal version for the rest of the compilers to support c++17 and
• 39ec833b - removed pgi compiler

Compare with previous version

added 1 commit

• 99505a1c - added explicit cast to real_t to avoid narrowing conversion

Compare with previous version

added 1 commit

• a7e32838 - Fixed the type cast to avoid implicit conversions

Compare with previous version

added 2 commits

• 750c8a4d - removed the nec compiler workarounds
• 60d07471 - removed the workaround for std::experimental::filesystem

Compare with previous version

changed the description

Just for documentation regarding the NEC compiler. I tried to build walberla on the aurora machine in the testcluster, but it did not work at all. The compiler there was called nc++and not sxc. And I think this nc++ did not support std::filesystem at all (neither in std::experimental or std). So I decided to also remove the specific options for this NEC SX compiler.

marked this merge request as ready

approved this merge request

resolved all threads

merged

mentioned in commit b2a3b880

mentioned in issue #78

mentioned in issue #262