Fix deprecation warning for Sympy 1.7
We have to try from newest to oldest import to avoid deprecation warnings.
They added the old import again, but with a deprecation warning.
Merge request reports
Activity
assigned to @holzer
@holzer please do not merge! The change from C99 to C11 might actually break code!
Let's try C99?
Edited by Stephan SeitzSeems to be fixed with C99 if it was related.
Edited by Stephan SeitzRemoved sympy < 1.1 (Probably it will not work anymore anyway)
There is also code in assignment.py for pre-1.1
Edited by Stephan SeitzYes, this is what I am thinking. We make too many changes which we do not test on very old sympy versions. Thus keeping the compatibility in some party of pystencils will not work. Additionally I don't think that this it is really neccessary to keep the compatibility with very old sympy versions.
Now conda and sympy-master are failing again? Re-triggered both. Failure seems to be in vectorization-test
Flaky tests?
Edited by Stephan Seitzadded 1 commit
- f212c921 - Remove own Assignment implementation for old SymPy versions
We used to have the ubuntu job in CI to test with old sympy versions (1.1). But then @holzer upgraded it to Ubuntu 20.04 (https://i10git.cs.fau.de/pycodegen/pycodegen/-/commit/fa8f958f61bc29520fa2a0d8b729dc48252ff4bd), which we should have probably not done until #21 (closed).