Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • W waLBerla
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 51
    • Issues 51
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • waLBerla
  • waLBerla
  • Merge requests
  • !453

Jinja2 3.0 compatibility

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michael Kuron requested to merge jinja2 into master May 15, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Some of the CI jobs install jinja2 via pip and thus use the recently-released jinja2 3.0.0. in !452 (merged), we are thus seeing

File "/builds/walberla/walberla/python/pystencils_walberla/kernel_selection.py", line 111, in get_code
    true_branch_code = do_indent(true_branch_code, width=4, indentfirst=True)
TypeError: do_indent() got an unexpected keyword argument 'indentfirst'

indentfirst has been deprecated sind 2.10 three years ago and was removed in 3.0.0, see https://github.com/pallets/jinja/commit/b0015c72d5acbf93b9d99a1ce6167889338db85b. Its usage was introduced into Walberla by @da15siwa in !446 (merged) two weeks ago.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: jinja2